I allowed myself to rebase the pr and apply some nit-pick suggestions. What is missing for me is a way to disable the functionality. It works well and the implementation is good but there will for sure be someone who wants the legacy behavior because of a missing distance sensor or special use case.

Added a comment in my additional commit on how to disable.

Thanks @MaEtUgR .
@PX4/testflights can you please test this PR and verify that when you are in position control mode, the speed is limited when close to the ground? Thanks

Tested on Pixhawk 4 v5 f-450
Position mode: no issues

log: https://review.px4.io/plot_app?log=359b3c8c-ccea-4949-a389-ef3a4065f354

PixRacer v4 f-450
position mode: no issues

log: https://review.px4.io/plot_app?log=4b200565-eb8f-49d5-8f04-b88d46987463

Observations:
We noticed when closest to the ground the speed would reduce or be limited when the altitude increased the speed increased. Regardless of the altitude, the vehicle seemed at a lower speed than normal when not close to the ground.

Tested on NXP FMUK66 v3

Mode Tested: Position Mode.

Procedure: Flight in Position mode and notice ground velocity change proporcional to the altitude of the vehicle.

Notes: No issue.

Log: https://review.px4.io/plot_app?log=b0be1815-e64c-4a6a-808f-b8adce9486db

Tested on Pixhawk Pro v4

Mode Tested: Position Mode.

Procedure: Flight in Position mode and notice ground velocity change proporcional to the altitude of the vehicle.

Notes: No issue.

Log: https://review.px4.io/plot_app?log=adab6003-a537-43c3-9c2e-4b31d6003962

Observations:
We noticed when closest to the ground the speed would reduce or be limited when the altitude increased the speed increased. Regardless of the altitude, the vehicle seemed at a lower speed than normal when not close to the ground.

I also did some real-world flight testing and if the altitudes MPC_LAND_ALT1, MPC_LAND_ALT2 are not super close like less than a meter to each other it works super nice. If they are too close the maximum allowed speed changes very quickly but that's a question of configuration. I consider this a good feature since especially with a downward-facing distance sensor manual landing even when coming from flying fast forward gets so easy.

I just confirmed an issue: If you go full stick while flying up the allowed velocity gets faster and faster but you acceleration is much lower than when you start flying on the same altitude even after you are long over MPC_LAND_ALT1

Full stick while crossing the altitudes looks like exactly 0.5m/s^2 while when starting in high altitude it looks like exactly 3m/s^2.

We found that it's not this pr creating the behavior that is shown above but the problem already existed before and it was only found by thoroughly testing this pr. @bresch will create another pr to get rid of this legacy logic. See https://github.com/PX4/Firmware/blob/a3d30fc970262a589ed2ac94c0c5bf18343162c0/src/lib/flight_tasks/tasks/ManualPosition/FlightTaskManualPosition.cpp#L104-L114